diff options
| author | liujunjie | 2018-07-24 15:43:39 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2018-07-28 09:09:58 +0200 |
| commit | ad63c549ecd4af4a22a675a815edeb06b0e7bb6e (patch) | |
| tree | 53071d44635706a7d6f59a9fecb0bac63d98d13e /include/exec | |
| parent | Update version for v3.0.0-rc2 release (diff) | |
| download | qemu-ad63c549ecd4af4a22a675a815edeb06b0e7bb6e.tar.gz qemu-ad63c549ecd4af4a22a675a815edeb06b0e7bb6e.tar.xz qemu-ad63c549ecd4af4a22a675a815edeb06b0e7bb6e.zip | |
qstring: Fix qstring_from_substr() not to provoke int overflow
qstring_from_substr() parameters @start and @end are of type int.
blkdebug_parse_filename(), blkverify_parse_filename(), nbd_parse_uri(),
and qstring_from_str() pass @end values of type size_t or ptrdiff_t.
Values exceeding INT_MAX get truncated, with possibly disastrous
results.
Such huge substrings seem unlikely, but we found one in a core dump,
where "info tlb" executed via QMP's human-monitor-command apparently
produced 35 GiB of output.
Fix by changing the parameters size_t.
Signed-off-by: liujunjie <liujunjie23@huawei.com>
Message-Id: <20180724134339.17832-1-liujunjie23@huawei.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions