diff options
| author | Stefan Hajnoczi | 2017-03-01 12:50:26 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2017-04-21 11:36:12 +0200 |
| commit | d72915c60bff51495529449750e051d01b03c62f (patch) | |
| tree | c88c623920e0b81b24afd435adad57c4e65c39d2 /include/exec | |
| parent | throttle: do not use invalid config in test (diff) | |
| download | qemu-d72915c60bff51495529449750e051d01b03c62f.tar.gz qemu-d72915c60bff51495529449750e051d01b03c62f.tar.xz qemu-d72915c60bff51495529449750e051d01b03c62f.zip | |
throttle: make throttle_config(throttle_get_config()) symmetric
Throttling has a weird property that throttle_get_config() does not
always return the same throttling settings that were given with
throttle_config(). In other words, the set and get functions aren't
symmetric.
If .max is 0 then the throttling code assigns a default value of .avg /
10 in throttle_config(). This is an implementation detail of the
throttling algorithm. When throttle_get_config() is called the .max
value returned should still be 0.
Users are exposed to this quirk via "info block" or "query-block"
monitor commands. This has caused confusion because it looks like a bug
when an unexpected value is reported.
This patch hides the .max value adjustment in throttle_get_config() and
updates test-throttle.c appropriately.
Reported-by: Nini Gu <ngu@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 20170301115026.22621-4-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions