diff options
| author | Daniel P. Berrange | 2016-02-12 15:46:50 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2016-02-16 09:27:59 +0100 |
| commit | e046fb449947a48e013bf25d806ecb60e5a88319 (patch) | |
| tree | 92bb6a5fad8951ec7ed97889322af55cabb122d6 /include/exec | |
| parent | Revert "qemu-char: Keep pty slave file descriptor open until the master is cl... (diff) | |
| download | qemu-e046fb449947a48e013bf25d806ecb60e5a88319.tar.gz qemu-e046fb449947a48e013bf25d806ecb60e5a88319.tar.xz qemu-e046fb449947a48e013bf25d806ecb60e5a88319.zip | |
char: fix handling of QIO_CHANNEL_ERR_BLOCK
If io_channel_send_full gets QIO_CHANNEL_ERR_BLOCK it
and has already sent some of the data, it should return
that amount of data, not EAGAIN, as that would cause
the caller to re-try already sent data.
Unfortunately due to a previous rebase conflict resolution
error, the code for dealing with this was in the wrong
part of the conditional, and so mistakenly ran on other
I/O errors.
This be seen running
qemu-system-x86_64 -monitor stdio
and entering 'info mtree', when running on a slow console
(eg a slow remote ssh session). The monitor would get into
an indefinite loop writing the same data until it managed
to send it all without getting EAGAIN.
Reported-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1455288410-27046-1-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions