diff options
| author | David Hildenbrand | 2018-06-19 15:41:41 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2018-06-28 19:05:34 +0200 |
| commit | f0b7bca64dbe8a15c1f4285c6061ce3c81a4a5c7 (patch) | |
| tree | caff083cd29ac9d855fa00c5d5d8f10055860e36 /include/hw/mem | |
| parent | nvdimm: make get_memory_region() perform checks and initialization (diff) | |
| download | qemu-f0b7bca64dbe8a15c1f4285c6061ce3c81a4a5c7.tar.gz qemu-f0b7bca64dbe8a15c1f4285c6061ce3c81a4a5c7.tar.xz qemu-f0b7bca64dbe8a15c1f4285c6061ce3c81a4a5c7.zip | |
pc-dimm: get_memory_region() will not fail after realize
Let's try to reduce error handling a bit. In the plug/unplug case, the
device was realized and therefore we can assume that getting access to
the memory region will not fail.
For get_vmstate_memory_region() this is already handled that way.
Document both cases.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20180619134141.29478-13-david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/hw/mem')
| -rw-r--r-- | include/hw/mem/pc-dimm.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index 5679a80465..26ebb7d5e9 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -62,9 +62,11 @@ typedef struct PCDIMMDevice { * @realize: called after common dimm is realized so that the dimm based * devices get the chance to do specified operations. * @get_memory_region: returns #MemoryRegion associated with @dimm which - * is directly mapped into the physical address space of guest. + * is directly mapped into the physical address space of guest. Will not + * fail after the device was realized. * @get_vmstate_memory_region: returns #MemoryRegion which indicates the - * memory of @dimm should be kept during live migration. + * memory of @dimm should be kept during live migration. Will not fail + * after the device was realized. */ typedef struct PCDIMMDeviceClass { /* private */ |