diff options
| author | Philippe Mathieu-Daudé | 2020-07-21 15:05:51 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé | 2020-07-21 16:47:31 +0200 |
| commit | a3ad58342a9d88d1baafc0aee39302f79faad480 (patch) | |
| tree | 2153c2d19eb541d458f6a55b34ccc0def4b4d9da /include/hw/nvram | |
| parent | Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07-2... (diff) | |
| download | qemu-a3ad58342a9d88d1baafc0aee39302f79faad480.tar.gz qemu-a3ad58342a9d88d1baafc0aee39302f79faad480.tar.xz qemu-a3ad58342a9d88d1baafc0aee39302f79faad480.zip | |
hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error propagation
Document FWCfgDataGeneratorClass::get_data() return NULL
on error, and non-NULL on success. This allow us to simplify
fw_cfg_add_from_generator(). Since we don't need a local
variable to propagate the error, we can remove the ERRP_GUARD()
macro.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200721131911.27380-2-philmd@redhat.com>
Diffstat (limited to 'include/hw/nvram')
| -rw-r--r-- | include/hw/nvram/fw_cfg.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h index 11feae3177..bbcf405649 100644 --- a/include/hw/nvram/fw_cfg.h +++ b/include/hw/nvram/fw_cfg.h @@ -32,7 +32,9 @@ typedef struct FWCfgDataGeneratorClass { * @obj: the object implementing this interface * @errp: pointer to a NULL-initialized error object * - * Returns: reference to a byte array containing the data. + * Returns: reference to a byte array containing the data on success, + * or NULL on error. + * * The caller should release the reference when no longer * required. */ |