diff options
| author | Markus Armbruster | 2014-10-24 13:19:11 +0200 |
|---|---|---|
| committer | Peter Maydell | 2014-10-24 13:19:11 +0200 |
| commit | 7797a73947d5c0e63dd5552b348cf66c384b4555 (patch) | |
| tree | 9e48798870378c8af03dfe2138682055768726a2 /include/hw/pcmcia.h | |
| parent | Merge remote-tracking branch 'remotes/qmp-unstable/tags/for-upstream' into st... (diff) | |
| download | qemu-7797a73947d5c0e63dd5552b348cf66c384b4555.tar.gz qemu-7797a73947d5c0e63dd5552b348cf66c384b4555.tar.xz qemu-7797a73947d5c0e63dd5552b348cf66c384b4555.zip | |
hmp: Remove "info pcmcia"
This command lists PCMCIA sockets and cards. Only a few ARM boards
have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
"microdrive"), and it is only inserted during machine init, if ever.
So this command doesn't really tell anybody anything new so far.
Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
by Coverity. Has never been used, because there has never been code
to eject a PCMCIA card.
Not worth fixing & converting to QMP. Remove it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
Acked-by: Andreas Färber <afaerber@suse.de>
Message-id: 1411144812-22958-1-git-send-email-armbru@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'include/hw/pcmcia.h')
| -rw-r--r-- | include/hw/pcmcia.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/include/hw/pcmcia.h b/include/hw/pcmcia.h index 2695d3cba6..98406ffbc9 100644 --- a/include/hw/pcmcia.h +++ b/include/hw/pcmcia.h @@ -8,14 +8,8 @@ typedef struct PCMCIASocket { qemu_irq irq; bool attached; - const char *slot_string; - const char *card_string; } PCMCIASocket; -void pcmcia_socket_register(PCMCIASocket *socket); -void pcmcia_socket_unregister(PCMCIASocket *socket); -void pcmcia_info(Monitor *mon, const QDict *qdict); - #define TYPE_PCMCIA_CARD "pcmcia-card" #define PCMCIA_CARD(obj) \ OBJECT_CHECK(PCMCIACardState, (obj), TYPE_PCMCIA_CARD) |