diff options
| author | Greg Kurz | 2020-11-21 00:42:01 +0100 |
|---|---|---|
| committer | David Gibson | 2020-12-14 05:50:55 +0100 |
| commit | ea042c53f4d9e48e7b3c84f5d0eb70a84aa34413 (patch) | |
| tree | d2a9f052765816b28a1c0dadd2c1f75e7eeb6250 /include/hw/ppc | |
| parent | spapr: Do PCI device hotplug sanity checks at pre-plug only (diff) | |
| download | qemu-ea042c53f4d9e48e7b3c84f5d0eb70a84aa34413.tar.gz qemu-ea042c53f4d9e48e7b3c84f5d0eb70a84aa34413.tar.xz qemu-ea042c53f4d9e48e7b3c84f5d0eb70a84aa34413.zip | |
spapr: Do NVDIMM/PC-DIMM device hotplug sanity checks at pre-plug only
Pre-plug of a memory device, be it an NVDIMM or a PC-DIMM, ensures
that the memory slot is available and that addresses don't overlap
with existing memory regions. The corresponding DRCs in the LMB
and PMEM namespaces are thus necessarily attachable at plug time.
Pass &error_abort to spapr_drc_attach() in spapr_add_lmbs() and
spapr_add_nvdimm(). This allows to greatly simplify error handling
on the plug path.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20201120234208.683521-3-groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'include/hw/ppc')
| -rw-r--r-- | include/hw/ppc/spapr_nvdimm.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/hw/ppc/spapr_nvdimm.h b/include/hw/ppc/spapr_nvdimm.h index 344582d2f5..73be250e2a 100644 --- a/include/hw/ppc/spapr_nvdimm.h +++ b/include/hw/ppc/spapr_nvdimm.h @@ -30,6 +30,6 @@ int spapr_pmem_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr, void spapr_dt_persistent_memory(SpaprMachineState *spapr, void *fdt); bool spapr_nvdimm_validate(HotplugHandler *hotplug_dev, NVDIMMDevice *nvdimm, uint64_t size, Error **errp); -bool spapr_add_nvdimm(DeviceState *dev, uint64_t slot, Error **errp); +void spapr_add_nvdimm(DeviceState *dev, uint64_t slot); #endif |