diff options
| author | Paolo Bonzini | 2020-10-07 18:23:56 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2020-10-12 17:50:22 +0200 |
| commit | 22fb6eb571387172f41878866f4438b6bae21f0e (patch) | |
| tree | 759479e8e9fd997d2a7791caf0e6278ff4cce91a /include/hw | |
| parent | exec: split out non-softmmu-specific parts (diff) | |
| download | qemu-22fb6eb571387172f41878866f4438b6bae21f0e.tar.gz qemu-22fb6eb571387172f41878866f4438b6bae21f0e.tar.xz qemu-22fb6eb571387172f41878866f4438b6bae21f0e.zip | |
qom: fix objects with improper parent type
Some objects accidentally inherit ObjectClass instead of Object.
They compile silently but may crash after downcasting.
In this patch, we introduce a coccinelle script to find broken
declarations and fix them manually with proper base type.
Signed-off-by: Sergey Nizovtsev <snizovtsev@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/hw')
| -rw-r--r-- | include/hw/acpi/vmgenid.h | 2 | ||||
| -rw-r--r-- | include/hw/misc/vmcoreinfo.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h index d50fbacb8e..cb4ad37fc5 100644 --- a/include/hw/acpi/vmgenid.h +++ b/include/hw/acpi/vmgenid.h @@ -19,7 +19,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VmGenIdState, VMGENID) struct VmGenIdState { - DeviceClass parent_obj; + DeviceState parent_obj; QemuUUID guid; /* The 128-bit GUID seen by the guest */ uint8_t vmgenid_addr_le[8]; /* Address of the GUID (little-endian) */ }; diff --git a/include/hw/misc/vmcoreinfo.h b/include/hw/misc/vmcoreinfo.h index ebada6617a..0b7b55d400 100644 --- a/include/hw/misc/vmcoreinfo.h +++ b/include/hw/misc/vmcoreinfo.h @@ -24,7 +24,7 @@ DECLARE_INSTANCE_CHECKER(VMCoreInfoState, VMCOREINFO, typedef struct fw_cfg_vmcoreinfo FWCfgVMCoreInfo; struct VMCoreInfoState { - DeviceClass parent_obj; + DeviceState parent_obj; bool has_vmcoreinfo; FWCfgVMCoreInfo vmcoreinfo; |