diff options
| author | Edgar Kaziakhmedov | 2018-01-10 16:39:24 +0100 |
|---|---|---|
| committer | Daniel P. Berrangé | 2018-02-15 17:54:57 +0100 |
| commit | a46ded1de5cf0edd6c780e071ddafb92601070b5 (patch) | |
| tree | 7f538816906bd367ebd670932587d311ca573174 /include/io | |
| parent | io: fix QIONetListener memory leak (diff) | |
| download | qemu-a46ded1de5cf0edd6c780e071ddafb92601070b5.tar.gz qemu-a46ded1de5cf0edd6c780e071ddafb92601070b5.tar.xz qemu-a46ded1de5cf0edd6c780e071ddafb92601070b5.zip | |
io/channel-websock: handle continuous reads without any data
According to the current implementation of websocket protocol in QEMU,
qio_channel_websock_handshake_io tries to read handshake from the
channel to start communication over socket. But this approach
doesn't cover scenario when socket was closed while handshaking.
Therefore, if G_IO_IN is caught and qio_channel_read returns zero,
error has to be set and connection has to be done.
Such behaviour causes 100% CPU load in main QEMU loop, because main loop
poll continues to receive and handle G_IO_IN events from websocket.
Step to reproduce 100% CPU load:
1) start qemu with the simplest configuration
$ qemu -vnc [::1]:1,websocket=7500
2) open any vnc listener (which doesn't follow websocket
protocol)
$ vncviewer :7500
3) kill listener
4) qemu main thread eats 100% CPU
Signed-off-by: Edgar Kaziakhmedov <edgar.kaziakhmedov@virtuozzo.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Diffstat (limited to 'include/io')
0 files changed, 0 insertions, 0 deletions
