diff options
| author | Dr. David Alan Gilbert | 2017-02-02 13:59:55 +0100 |
|---|---|---|
| committer | Juan Quintela | 2017-02-06 13:36:49 +0100 |
| commit | 581f08bac22bdd5e081ae07f68071a0fc3c5c2c7 (patch) | |
| tree | d8d094240391437df6994e6c49938c2a2cbd018f /include/migration | |
| parent | vmstate_register_with_alias_id: Take an Error ** (diff) | |
| download | qemu-581f08bac22bdd5e081ae07f68071a0fc3c5c2c7.tar.gz qemu-581f08bac22bdd5e081ae07f68071a0fc3c5c2c7.tar.xz qemu-581f08bac22bdd5e081ae07f68071a0fc3c5c2c7.zip | |
migration: Check for ID length
The qdev id of a device can be huge if it's on the end of a chain
of bridges; in reality such chains shouldn't occur but they can
be made to by chaining PCIe bridges together.
The migration format has a number of 256 character long format
limits; check we don't hit them (we already use pstrcat/cpy but
that just protects us from buffer overruns, we fairly quickly
hit an assert).
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20170202125956.21942-3-dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'include/migration')
| -rw-r--r-- | include/migration/vmstate.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index c38b00a6f1..6233fe2e5b 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -985,12 +985,14 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd, bool vmstate_save_needed(const VMStateDescription *vmsd, void *opaque); +/* Returns: 0 on success, -1 on failure */ int vmstate_register_with_alias_id(DeviceState *dev, int instance_id, const VMStateDescription *vmsd, void *base, int alias_id, int required_for_version, Error **errp); +/* Returns: 0 on success, -1 on failure */ static inline int vmstate_register(DeviceState *dev, int instance_id, const VMStateDescription *vmsd, void *opaque) |