summaryrefslogtreecommitdiffstats
path: root/include/monitor
diff options
context:
space:
mode:
authorYury Kotov2019-05-23 11:44:33 +0200
committerMarkus Armbruster2019-06-17 20:36:56 +0200
commit854f63d44065567c2991b5050f7d4011ca985c4e (patch)
tree2d98fc1c268d82e4e9fbf2882cec3ee589aa8fdd /include/monitor
parentMerge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' into ... (diff)
downloadqemu-854f63d44065567c2991b5050f7d4011ca985c4e.tar.gz
qemu-854f63d44065567c2991b5050f7d4011ca985c4e.tar.xz
qemu-854f63d44065567c2991b5050f7d4011ca985c4e.zip
monitor: Fix return type of monitor_fdset_dup_fd_find
monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find() return mon_fdset->id which is int64_t. Downcasting from int64_t to int leads to a bug with removing fd from fdset with id >= 2^32. So, fix return types for these function. Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru> Reviewed-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190523094433.30297-1-yury-kotov@yandex-team.ru> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'include/monitor')
-rw-r--r--include/monitor/monitor.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index 06cfcd8f36..1e1d6d2269 100644
--- a/include/monitor/monitor.h
+++ b/include/monitor/monitor.h
@@ -44,6 +44,6 @@ AddfdInfo *monitor_fdset_add_fd(int fd, bool has_fdset_id, int64_t fdset_id,
int monitor_fdset_get_fd(int64_t fdset_id, int flags);
int monitor_fdset_dup_fd_add(int64_t fdset_id, int dup_fd);
void monitor_fdset_dup_fd_remove(int dup_fd);
-int monitor_fdset_dup_fd_find(int dup_fd);
+int64_t monitor_fdset_dup_fd_find(int dup_fd);
#endif /* MONITOR_H */