diff options
| author | Igor Mammedov | 2016-03-01 10:40:48 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2016-03-11 13:55:15 +0100 |
| commit | c9f4b77ad5783bd84bca4ab99d4b3d6ee61de01c (patch) | |
| tree | e1d576700ca73345cf37500876c3f3a65047d7bf /include/monitor | |
| parent | vhost-user: verify that number of queues is less than MAX_QUEUE_NUM (diff) | |
| download | qemu-c9f4b77ad5783bd84bca4ab99d4b3d6ee61de01c.tar.gz qemu-c9f4b77ad5783bd84bca4ab99d4b3d6ee61de01c.tar.xz qemu-c9f4b77ad5783bd84bca4ab99d4b3d6ee61de01c.zip | |
pc-dimm: fix error handling in pc_dimm_check_memdev_is_busy()
If host_memory_backend_get_memory() were to return error and
NULL MemoryRegion, pc_dimm_check_memdev_is_busy() would crash
dereferencing NULL pointer in memory_region_is_mapped().
But if error is set and non NULL MemoryRegion is returned
then error_setg() will fail with "error already set" assertion
in error_setv()
To avoid above issues use typical error handling pattern
for property setters:
Error *local_error = NULL;
...
error_propagate(errp, local_err);
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/monitor')
0 files changed, 0 insertions, 0 deletions
