diff options
| author | Markus Armbruster | 2019-12-04 10:36:17 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2019-12-18 08:36:15 +0100 |
| commit | 8574c9f1ad905e473593230308a0b2a68c46ebe3 (patch) | |
| tree | a738cb98df766882d975826b31a9a012d630f850 /include/qapi | |
| parent | qga: Fix guest-get-fsinfo error API violations (diff) | |
| download | qemu-8574c9f1ad905e473593230308a0b2a68c46ebe3.tar.gz qemu-8574c9f1ad905e473593230308a0b2a68c46ebe3.tar.xz qemu-8574c9f1ad905e473593230308a0b2a68c46ebe3.zip | |
memory-device: Fix memory pre-plug error API violations
memory_device_get_free_addr() dereferences @errp when
memory_device_check_addable() fails. That's wrong; see the big
comment in error.h. Introduced in commit 1b6d6af21b "pc-dimm: factor
out capacity and slot checks into MemoryDevice".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-11-armbru@redhat.com>
Diffstat (limited to 'include/qapi')
0 files changed, 0 insertions, 0 deletions