diff options
| author | Vladimir Sementsov-Ogievskiy | 2019-08-29 11:09:53 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2019-09-10 08:58:43 +0200 |
| commit | bb0c94099382b52734a4a4f3c060e90c9a2ac6cf (patch) | |
| tree | ac02b2959676479a50414ee2144fc433681526b1 /include/qemu/job.h | |
| parent | qcow2: Fix the calculation of the maximum L2 cache size (diff) | |
| download | qemu-bb0c94099382b52734a4a4f3c060e90c9a2ac6cf.tar.gz qemu-bb0c94099382b52734a4a4f3c060e90c9a2ac6cf.tar.xz qemu-bb0c94099382b52734a4a4f3c060e90c9a2ac6cf.zip | |
job: drop job_drain
In job_finish_sync job_enter should be enough for a job to make some
progress and draining is a wrong tool for it. So use job_enter directly
here and drop job_drain with all related staff not used more.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/qemu/job.h')
| -rw-r--r-- | include/qemu/job.h | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/include/qemu/job.h b/include/qemu/job.h index 73c67d3175..bd59cd8944 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@ -220,13 +220,6 @@ struct JobDriver { */ void (*complete)(Job *job, Error **errp); - /* - * If the callback is not NULL, it will be invoked when the job has to be - * synchronously cancelled or completed; it should drain any activities - * as required to ensure progress. - */ - void (*drain)(Job *job); - /** * If the callback is not NULL, prepare will be invoked when all the jobs * belonging to the same transaction complete; or upon this job's completion @@ -470,12 +463,6 @@ bool job_user_paused(Job *job); */ void job_user_resume(Job *job, Error **errp); -/* - * Drain any activities as required to ensure progress. This can be called in a - * loop to synchronously complete a job. - */ -void job_drain(Job *job); - /** * Get the next element from the list of block jobs after @job, or the * first one if @job is %NULL. |