diff options
| author | Alex Bennée | 2020-07-24 08:45:01 +0200 |
|---|---|---|
| committer | Alex Bennée | 2020-07-27 10:41:18 +0200 |
| commit | 2667e069e7b5807c69f32109d930967bc1b222cb (patch) | |
| tree | 7b24dbe48c14f5e0c2c8809dcfa359ef679f1aa0 /include/qemu/osdep.h | |
| parent | target/i386: floatx80: avoid compound literals in static initializers (diff) | |
| download | qemu-2667e069e7b5807c69f32109d930967bc1b222cb.tar.gz qemu-2667e069e7b5807c69f32109d930967bc1b222cb.tar.xz qemu-2667e069e7b5807c69f32109d930967bc1b222cb.zip | |
linux-user: don't use MAP_FIXED in pgd_find_hole_fallback
Plain MAP_FIXED has the undesirable behaviour of splatting exiting
maps so we don't actually achieve what we want when looking for gaps.
We should be using MAP_FIXED_NOREPLACE. As this isn't always available
we need to potentially check the returned address to see if the kernel
gave us what we asked for.
Fixes: ad592e37dfc ("linux-user: provide fallback pgd_find_hole for bare chroots")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200724064509.331-9-alex.bennee@linaro.org>
Diffstat (limited to 'include/qemu/osdep.h')
| -rw-r--r-- | include/qemu/osdep.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 0b1298b3c9..20872e793e 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -173,6 +173,9 @@ extern int daemon(int, int); #ifndef MAP_ANONYMOUS #define MAP_ANONYMOUS MAP_ANON #endif +#ifndef MAP_FIXED_NOREPLACE +#define MAP_FIXED_NOREPLACE 0 +#endif #ifndef ENOMEDIUM #define ENOMEDIUM ENODEV #endif |