diff options
author | Markus Armbruster | 2020-05-05 17:29:13 +0200 |
---|---|---|
committer | Markus Armbruster | 2020-05-15 06:26:02 +0200 |
commit | 44a17fe05a363d0f94cd0706fbe64cb4524adf54 (patch) | |
tree | bea77e379bd3083b24fb5d983e83df8495e52cf0 /include/qom | |
parent | qom: Simplify object_property_get_enum() (diff) | |
download | qemu-44a17fe05a363d0f94cd0706fbe64cb4524adf54.tar.gz qemu-44a17fe05a363d0f94cd0706fbe64cb4524adf54.tar.xz qemu-44a17fe05a363d0f94cd0706fbe64cb4524adf54.zip |
qom: Drop convenience method object_property_get_uint16List()
qom/object.c provides object_property_get_TYPE() and
object_property_set_TYPE() for a number of common types. These are
all convenience wrappers around object_property_get_qobject() and
object_property_set_qobject().
Except for object_property_get_uint16List(), which is unusual in two ways:
* It bypasses object_property_get_qobject(). Fixable; the previous
commit did it for object_property_get_enum())
* It stores the value through a parameter. Its contract claims it
returns the value, like the other functions do. Also fixable.
Fixing is not worthwhile, though: object_property_get_uint16List() has
seen exactly one user in six years.
Convert the lone user to do its job with the generic
object_property_get_qobject(), and drop object_property_get_uint16List().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505152926.18877-6-armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
[Commit message typo fixed]
Diffstat (limited to 'include/qom')
-rw-r--r-- | include/qom/object.h | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/include/qom/object.h b/include/qom/object.h index ccfa82e33d..4df9ecebad 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1321,20 +1321,6 @@ int object_property_get_enum(Object *obj, const char *name, const char *typename, Error **errp); /** - * object_property_get_uint16List: - * @obj: the object - * @name: the name of the property - * @list: the returned int list - * @errp: returns an error if this function fails - * - * Returns: the value of the property, converted to integers, or - * undefined if an error occurs (including when the property value is not - * an list of integers). - */ -void object_property_get_uint16List(Object *obj, const char *name, - uint16List **list, Error **errp); - -/** * object_property_set: * @obj: the object * @v: the visitor that will be used to write the property value. This should |