diff options
| author | Stefan Hajnoczi | 2018-02-01 12:07:08 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2018-02-15 10:39:49 +0100 |
| commit | 00d09fdbbae5f7864ce754913efc84c12fdf9f1a (patch) | |
| tree | f6085750008fb10a013c0a4917ac5198fafd3781 /include | |
| parent | Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (diff) | |
| download | qemu-00d09fdbbae5f7864ce754913efc84c12fdf9f1a.tar.gz qemu-00d09fdbbae5f7864ce754913efc84c12fdf9f1a.tar.xz qemu-00d09fdbbae5f7864ce754913efc84c12fdf9f1a.zip | |
vl: pause vcpus before stopping iothreads
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads
before main() quits") introduced iothread_stop_all() to avoid the
following virtio-scsi assertion failure:
assert(blk_get_aio_context(d->conf.blk) == s->ctx);
Back then the assertion failed because when bdrv_close_all() made
d->conf.blk NULL, blk_get_aio_context() returned the global AioContext
instead of s->ctx.
The same assertion can still fail today when vcpus submit new I/O
requests after iothread_stop_all() has moved the BDS to the global
AioContext.
This patch hardens the iothread_stop_all() approach by pausing vcpus
before calling iothread_stop_all().
Note that the assertion failure is a race condition. It is not possible
to reproduce it reliably.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20180201110708.8080-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions