diff options
| author | Pavel Dovgalyuk | 2014-10-30 10:31:00 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2014-10-31 11:29:02 +0100 |
| commit | 076893d3d06fe8642b8912591b9222bcb81f85aa (patch) | |
| tree | 80bbbd5cf08f8b9644fdec4faf1ca742501e5ccb /include | |
| parent | vl.c: Fix Coverity complaining for vmstate_dump_file (diff) | |
| download | qemu-076893d3d06fe8642b8912591b9222bcb81f85aa.tar.gz qemu-076893d3d06fe8642b8912591b9222bcb81f85aa.tar.xz qemu-076893d3d06fe8642b8912591b9222bcb81f85aa.zip | |
kvmvapic: patch_instruction fix
When QEMU works in icount mode cpu_restore_state function performs two actions:
restoring the program counter and updating icount to the correct value.
kvmvapic's patch_instruction function is called by cpu_report_tpr_access
function which also invokes cpu_restore_state. It results to calling
cpu_restore_state twice - in cpu_report_tpr_access and in patch_instruction.
When icount is disabled second call is safe. But when icount is enabled,
cpu_restore_state modifies instructions counter twice, which leads to incorrect
behavior. This patch removes useless cpu_restore_state call from kvmvapic.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions