diff options
| author | Vladimir Sementsov-Ogievskiy | 2022-07-26 22:11:25 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2022-10-27 20:14:11 +0200 |
| commit | 1921b4f7868cb398a8939b48e2cdac4d6ff79e41 (patch) | |
| tree | 5a3b87972ab137a2f25a3260924e99bca8b30859 /include | |
| parent | tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing (diff) | |
| download | qemu-1921b4f7868cb398a8939b48e2cdac4d6ff79e41.tar.gz qemu-1921b4f7868cb398a8939b48e2cdac4d6ff79e41.tar.xz qemu-1921b4f7868cb398a8939b48e2cdac4d6ff79e41.zip | |
test-bdrv-graph-mod: fix filters to be filters
bdrv_pass_through is used as filter, even all node variables has
corresponding names. We want to append it, so it should be
backing-child-based filter like mirror_top.
So, in test_update_perm_tree, first child should be DATA, as we don't
want filters with two filtered children.
bdrv_exclusive_writer is used as a filter once. So it should be filter
anyway. We want to append it, so it should be backing-child-based
fitler too.
Make all FILTERED children to be PRIMARY as well. We are going to force
this rule by assertion soon.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220726201134.924743-7-vsementsov@yandex-team.ru>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/block/block_int-common.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index 95392052c9..10feef9f0c 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -122,8 +122,9 @@ struct BlockDriver { /* * Only make sense for filter drivers, for others must be false. * If true, filtered child is bs->backing. Otherwise it's bs->file. - * Only two internal filters use bs->backing as filtered child and has this - * field set to true: mirror_top and commit_top. + * Two internal filters use bs->backing as filtered child and has this + * field set to true: mirror_top and commit_top. There also two such test + * filters in tests/unit/test-bdrv-graph-mod.c. * * Never create any more such filters! * |