summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorPeter Maydell2014-04-15 20:18:40 +0200
committerPeter Maydell2014-04-17 22:34:03 +0200
commit2c7ffc414d8591018248b5487757e45f7bb6bd3c (patch)
tree4d4d2e4ec155fb23905b7160f023113645232aca /include
parenttarget-arm: A64: Add assertion that FP access was checked (diff)
downloadqemu-2c7ffc414d8591018248b5487757e45f7bb6bd3c.tar.gz
qemu-2c7ffc414d8591018248b5487757e45f7bb6bd3c.tar.xz
qemu-2c7ffc414d8591018248b5487757e45f7bb6bd3c.zip
target-arm: Fix VFP enables for AArch32 EL0 under AArch64 EL1
The current A32/T32 decoder bases its "is VFP/Neon enabled?" check on the FPSCR.EN bit. This is correct if EL1 is AArch32, but for an AArch64 EL1 the logic is different: it must act as if FPSCR.EN is always set. Instead, trapping must happen according to CPACR bits for cp10/cp11; these cover all of FP/Neon, including the FPSCR/FPSID/MVFR register accesses which FPSCR.EN does not affect. Add support for CPACR checks (which are also required for ARMv7, but were unimplemented because Linux happens not to use them) and make sure they generate exceptions with the correct syndrome. We actually return incorrect syndrome information for cases where FP is disabled but the specific instruction bit pattern is unallocated: strictly these should be the Uncategorized exception, not a "SIMD disabled" exception. This should be mostly harmless, and the structure of the A32/T32 VFP/Neon decoder makes it painful to put the 'FP disabled?' checks in the right places. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions