diff options
| author | Peter Maydell | 2018-06-15 15:57:14 +0200 |
|---|---|---|
| committer | Peter Maydell | 2018-06-15 16:23:34 +0200 |
| commit | 2d54f19401bc54b3b56d1cc44c96e4087b604b97 (patch) | |
| tree | d284c1967616f8f77fc36226f64459c2bb362bba /include | |
| parent | cpu-defs.h: Document CPUIOTLBEntry 'addr' field (diff) | |
| download | qemu-2d54f19401bc54b3b56d1cc44c96e4087b604b97.tar.gz qemu-2d54f19401bc54b3b56d1cc44c96e4087b604b97.tar.xz qemu-2d54f19401bc54b3b56d1cc44c96e4087b604b97.zip | |
cputlb: Pass cpu_transaction_failed() the correct physaddr
The API for cpu_transaction_failed() says that it takes the physical
address for the failed transaction. However we were actually passing
it the offset within the target MemoryRegion. We don't currently
have any target CPU implementations of this hook that require the
physical address; fix this bug so we don't get confused if we ever
do add one.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20180611125633.32755-3-peter.maydell@linaro.org
Diffstat (limited to 'include')
| -rw-r--r-- | include/exec/exec-all.h | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 4d09eaba72..aed55aaaa7 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -437,8 +437,17 @@ void tb_lock_reset(void); #if !defined(CONFIG_USER_ONLY) -struct MemoryRegion *iotlb_to_region(CPUState *cpu, - hwaddr index, MemTxAttrs attrs); +/** + * iotlb_to_section: + * @cpu: CPU performing the access + * @index: TCG CPU IOTLB entry + * + * Given a TCG CPU IOTLB entry, return the MemoryRegionSection that + * it refers to. @index will have been initially created and returned + * by memory_region_section_get_iotlb(). + */ +struct MemoryRegionSection *iotlb_to_section(CPUState *cpu, + hwaddr index, MemTxAttrs attrs); void tlb_fill(CPUState *cpu, target_ulong addr, int size, MMUAccessType access_type, int mmu_idx, uintptr_t retaddr); |