diff options
| author | Greg Kurz | 2016-02-05 11:46:04 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2016-02-16 11:05:18 +0100 |
| commit | 46f70ff148ae01e2dc96e64c393e295a0092555d (patch) | |
| tree | 68417b8f64f7019d9a7fd488f6d4ba858accb3b3 /include | |
| parent | vhost: move virtio 1.0 check to cross-endian helper (diff) | |
| download | qemu-46f70ff148ae01e2dc96e64c393e295a0092555d.tar.gz qemu-46f70ff148ae01e2dc96e64c393e295a0092555d.tar.xz qemu-46f70ff148ae01e2dc96e64c393e295a0092555d.zip | |
vhost: simplify vhost_needs_vring_endian()
After the call to virtio_vdev_has_feature(), we only care for legacy
devices, so we don't need the extra check in virtio_is_big_endian().
Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN
may only happen on a virtio_load() path that cannot lead here), so we
don't need the assert() either.
This open codes the device_endian checking in vhost_needs_vring_endian().
It also adds a comment to explain the logic, as recent reviews showed the
cross-endian tweaks aren't that obvious.
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
