diff options
| author | Markus Armbruster | 2018-10-17 10:26:52 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2018-10-19 14:51:34 +0200 |
| commit | 4f7ec696f4b124364c1b145dbe835984edc4c887 (patch) | |
| tree | 35438ba1b9d254748a28b02429c6b844a2e34072 /include | |
| parent | vnc: Clean up error reporting in vnc_init_func() (diff) | |
| download | qemu-4f7ec696f4b124364c1b145dbe835984edc4c887.tar.gz qemu-4f7ec696f4b124364c1b145dbe835984edc4c887.tar.xz qemu-4f7ec696f4b124364c1b145dbe835984edc4c887.zip | |
numa: Clean up error reporting in parse_numa()
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_numa() does that, and then fails without setting
an error. Its caller main(), via qemu_opts_foreach(), is fine with
it, but clean it up anyway.
While there, give parse_numa() internal linkage.
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20181017082702.5581-29-armbru@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sysemu/numa.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h index 7a0ae751aa..21713b7e2f 100644 --- a/include/sysemu/numa.h +++ b/include/sysemu/numa.h @@ -22,7 +22,6 @@ struct NumaNodeMem { }; extern NodeInfo numa_info[MAX_NODES]; -int parse_numa(void *opaque, QemuOpts *opts, Error **errp); void parse_numa_opts(MachineState *ms); void numa_complete_configuration(MachineState *ms); void query_numa_node_mem(NumaNodeMem node_mem[]); |