diff options
| author | Bin Meng | 2022-04-21 07:56:29 +0200 |
|---|---|---|
| committer | Alistair Francis | 2022-04-29 02:47:45 +0200 |
| commit | 58303fc0be8ccd7557414a920d4c666fce36eb41 (patch) | |
| tree | 900873ca93397a3faf1c3f538c050692bc532276 /include | |
| parent | hw/riscv: spike: Add '/chosen/stdout-path' in device tree unconditionally (diff) | |
| download | qemu-58303fc0be8ccd7557414a920d4c666fce36eb41.tar.gz qemu-58303fc0be8ccd7557414a920d4c666fce36eb41.tar.xz qemu-58303fc0be8ccd7557414a920d4c666fce36eb41.zip | |
hw/riscv: Don't add empty bootargs to device tree
Commit 7c28f4da20e5 ("RISC-V: Don't add NULL bootargs to device-tree")
tried to avoid adding *NULL* bootargs to device tree, but unfortunately
the changes were entirely useless, due to MachineState::kernel_cmdline
can't be NULL at all as the default value is given as an empty string.
(see hw/core/machine.c::machine_initfn()).
Note the wording of *NULL* bootargs is wrong. It can't be NULL otherwise
a segfault had already been observed by dereferencing the NULL pointer.
It should be worded as *empty" bootargs.
Fixes: 7c28f4da20e5 ("RISC-V: Don't add NULL bootargs to device-tree")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20220421055629.1177285-2-bmeng.cn@gmail.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions