diff options
| author | Igor Mammedov | 2020-05-11 16:11:02 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2020-06-10 18:09:34 +0200 |
| commit | 59d55a16edfac087248dc60dd9525bdfcc057bb1 (patch) | |
| tree | 2562537138650d49d818eb5cc618817283b23fc1 /include | |
| parent | run-coverity-scan: support --update-tools-only --docker (diff) | |
| download | qemu-59d55a16edfac087248dc60dd9525bdfcc057bb1.tar.gz qemu-59d55a16edfac087248dc60dd9525bdfcc057bb1.tar.xz qemu-59d55a16edfac087248dc60dd9525bdfcc057bb1.zip | |
vl.c: run preconfig loop before creating default RAM backend
Default RAM backend depends on numa_uses_legacy_mem(), which is
infulenced by -numa options on CLI or set-numa-node QMP command
at preconfig time. If QEMU is started with '-preconfig'
without -numa, it will lead to creating default RAM backend
even if later set-numa-node is used to assing RAM to NUMA nodes
using 'memdev' NUMA option.
That at best will waste RAM object created by default and with
next patch adding a check to prevent usage of conflicting
'-M memory-backend' and '-numa memdev'
options, it will make QEMU error out if user tries to configure
NUMA at preconfig time with memdev option, making set-numa-node
unusable.
To fix issue, move preconfig loop before default RAM backend is
created, so that numa_uses_legacy_mem() would take into account
effects of set-numa-node commands executed at preconfig time.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200511141103.43768-2-imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions