diff options
| author | Juan Quintela | 2013-10-09 12:26:23 +0200 |
|---|---|---|
| committer | Juan Quintela | 2014-01-13 14:04:54 +0100 |
| commit | 5b9a3a5f77e3458af6c1bb0654ee0f32936a5594 (patch) | |
| tree | 76629b7548176ad77a0facad2856a5089cd6d494 /include | |
| parent | memory: use find_next_bit() to find dirty bits (diff) | |
| download | qemu-5b9a3a5f77e3458af6c1bb0654ee0f32936a5594.tar.gz qemu-5b9a3a5f77e3458af6c1bb0654ee0f32936a5594.tar.xz qemu-5b9a3a5f77e3458af6c1bb0654ee0f32936a5594.zip | |
memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations
We were setting a range of bits, so use bitmap_set().
Note: xen has always been wrong, and should have used start instead
of addr from the beginning.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/exec/memory-internal.h | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b017c2ec98..4906cdf0ea 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -81,19 +81,14 @@ static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr, static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, ram_addr_t length) { - ram_addr_t addr, end; + unsigned long end, page; - end = TARGET_PAGE_ALIGN(start + length); - start &= TARGET_PAGE_MASK; - for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { - set_bit(addr >> TARGET_PAGE_BITS, - ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]); - set_bit(addr >> TARGET_PAGE_BITS, - ram_list.dirty_memory[DIRTY_MEMORY_VGA]); - set_bit(addr >> TARGET_PAGE_BITS, - ram_list.dirty_memory[DIRTY_MEMORY_CODE]); - } - xen_modified_memory(addr, length); + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; + page = start >> TARGET_PAGE_BITS; + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION], page, end - page); + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_VGA], page, end - page); + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_CODE], page, end - page); + xen_modified_memory(start, length); } static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, |