diff options
| author | Greg Kurz | 2020-11-21 00:42:00 +0100 |
|---|---|---|
| committer | David Gibson | 2020-12-14 05:50:55 +0100 |
| commit | 9e4dc0a1c2743cb115ebdb32258a78b328c05205 (patch) | |
| tree | bf0e113fd97dca54171af4f4f778cf90f1cc83cc /include | |
| parent | spapr/xics: Drop unused argument to xics_kvm_has_broken_disconnect() (diff) | |
| download | qemu-9e4dc0a1c2743cb115ebdb32258a78b328c05205.tar.gz qemu-9e4dc0a1c2743cb115ebdb32258a78b328c05205.tar.xz qemu-9e4dc0a1c2743cb115ebdb32258a78b328c05205.zip | |
spapr: Do PCI device hotplug sanity checks at pre-plug only
The PHB acts as the hotplug handler for PCI devices. It does some
sanity checks on DR enablement, PCI bridge chassis numbers and
multifunction. These checks are currently performed at plug time,
but they would best sit in a pre-plug handler in order to error
out as early as possible.
Create a spapr_pci_pre_plug() handler and move all the checking
there. Add a check that the associated DRC doesn't already have
an attached device. This is equivalent to the slot availability
check performed by do_pci_register_device() upon realization of
the PCI device.
This allows to pass &error_abort to spapr_drc_attach() and to end
up with a plug handler that doesn't need to report errors anymore.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20201120234208.683521-2-groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions