diff options
| author | Peter Xu | 2021-05-06 18:05:48 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2021-05-26 14:49:46 +0200 |
| commit | a81a592698c5cf3d84486b00c84b7979dfa0a3da (patch) | |
| tree | dd43f42826f474eb69096c9309234939961b95e0 /include | |
| parent | KVM: Add dirty-ring-size property (diff) | |
| download | qemu-a81a592698c5cf3d84486b00c84b7979dfa0a3da.tar.gz qemu-a81a592698c5cf3d84486b00c84b7979dfa0a3da.tar.xz qemu-a81a592698c5cf3d84486b00c84b7979dfa0a3da.zip | |
KVM: Disable manual dirty log when dirty ring enabled
KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 is for KVM_CLEAR_DIRTY_LOG, which is only
useful for KVM_GET_DIRTY_LOG. Skip enabling it for kvm dirty ring.
More importantly, KVM_DIRTY_LOG_INITIALLY_SET will not wr-protect all the pages
initially, which is against how kvm dirty ring is used - there's no way for kvm
dirty ring to re-protect a page before it's notified as being written first
with a GFN entry in the ring! So when KVM_DIRTY_LOG_INITIALLY_SET is enabled
with dirty ring, we'll see silent data loss after migration.
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20210506160549.130416-10-peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions