summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorPeter Xu2017-05-19 05:19:41 +0200
committerMichael S. Tsirkin2017-05-25 20:25:27 +0200
commitad523590f62cf5d44e97388de370d27b95b25aff (patch)
treeed655b12b21d9c9b5507fed8ed3be9ca17ea54da /include
parentmemory: tune last param of iommu_ops.translate() (diff)
downloadqemu-ad523590f62cf5d44e97388de370d27b95b25aff.tar.gz
qemu-ad523590f62cf5d44e97388de370d27b95b25aff.tar.xz
qemu-ad523590f62cf5d44e97388de370d27b95b25aff.zip
memory: remove the last param in memory_region_iommu_replay()
We were always passing in that one as "false" to assume that's an read operation, and we also assume that IOMMU translation would always have that read permission. A better permission would be IOMMU_NONE since the replay is after all not a real read operation, but just a page table rebuilding process. CC: David Gibson <david@gibson.dropbear.id.au> CC: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Acked-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'include')
-rw-r--r--include/exec/memory.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 97fd0c242b..bfdc685f24 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -731,11 +731,8 @@ void memory_region_register_iommu_notifier(MemoryRegion *mr,
*
* @mr: the memory region to observe
* @n: the notifier to which to replay iommu mappings
- * @is_write: Whether to treat the replay as a translate "write"
- * through the iommu
*/
-void memory_region_iommu_replay(MemoryRegion *mr, IOMMUNotifier *n,
- bool is_write);
+void memory_region_iommu_replay(MemoryRegion *mr, IOMMUNotifier *n);
/**
* memory_region_iommu_replay_all: replay existing IOMMU translations