summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorPeter Maydell2021-07-25 19:44:05 +0200
committerRichard Henderson2021-07-26 18:56:03 +0200
commitc8cf47a946200239826e58abc203dcaa4fdbb30c (patch)
tree056644e66875fa1c5eaea710427a61abd34726b0 /include
parentaccel/tcg: Don't use CF_COUNT_MASK as the max value of icount_decr.u16.low (diff)
downloadqemu-c8cf47a946200239826e58abc203dcaa4fdbb30c.tar.gz
qemu-c8cf47a946200239826e58abc203dcaa4fdbb30c.tar.xz
qemu-c8cf47a946200239826e58abc203dcaa4fdbb30c.zip
accel/tcg: Remove unnecessary check on icount_extra in cpu_loop_exec_tb()
In cpu_loop_exec_tb(), we decide whether to look for a TB with exactly insns_left instructions in it using the condition (!cpu->icount_extra && insns_left > 0 && insns_left < tb->icount) The check for icount_extra == 0 is unnecessary, because we just set insns_left = MIN(0xffff, cpu->icount_budget); icount_extra = icount_budget - insns_left; and so icount_extra can only be non-zero if icount_budget > 0xffff and insns_left == 0xffff. But in that case insns_left >= tb->icount because 0xffff is much larger than TCG_MAX_INSNS, so the condition will be false anyway. Remove the unnecessary check, and instead assert: * that we are only going to execute a partial TB here if the icount budget has run out (ie icount_extra == 0) * that the number of insns we're going to execute does fit into the CF_COUNT_MASK Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20210725174405.24568-3-peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions