summaryrefslogtreecommitdiffstats
path: root/io
diff options
context:
space:
mode:
authorMarc-André Lureau2022-04-25 10:53:37 +0200
committerMarc-André Lureau2022-05-03 13:47:59 +0200
commit05e50e8fe5fed707653e1e5e2f2871f253a70452 (patch)
treefd87f387ad196e25227371ae1e6e238b136545bd /io
parentReplace fcntl(O_NONBLOCK) with g_unix_set_fd_nonblocking() (diff)
downloadqemu-05e50e8fe5fed707653e1e5e2f2871f253a70452.tar.gz
qemu-05e50e8fe5fed707653e1e5e2f2871f253a70452.tar.xz
qemu-05e50e8fe5fed707653e1e5e2f2871f253a70452.zip
io: make qio_channel_command_new_pid() static
The function isn't used outside of qio_channel_command_new_spawn(), which is !win32-specific. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'io')
-rw-r--r--io/channel-command.c26
1 files changed, 22 insertions, 4 deletions
diff --git a/io/channel-command.c b/io/channel-command.c
index 539685ea83..0790ac7895 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -26,8 +26,28 @@
#include "qemu/sockets.h"
#include "trace.h"
-
-QIOChannelCommand *
+#ifndef WIN32
+/**
+ * qio_channel_command_new_pid:
+ * @writefd: the FD connected to the command's stdin
+ * @readfd: the FD connected to the command's stdout
+ * @pid: the PID of the running child command
+ * @errp: pointer to a NULL-initialized error object
+ *
+ * Create a channel for performing I/O with the
+ * previously spawned command identified by @pid.
+ * The two file descriptors provide the connection
+ * to command's stdio streams, either one or which
+ * may be -1 to indicate that stream is not open.
+ *
+ * The channel will take ownership of the process
+ * @pid and will kill it when closing the channel.
+ * Similarly it will take responsibility for
+ * closing the file descriptors @writefd and @readfd.
+ *
+ * Returns: the command channel object, or NULL on error
+ */
+static QIOChannelCommand *
qio_channel_command_new_pid(int writefd,
int readfd,
pid_t pid)
@@ -44,8 +64,6 @@ qio_channel_command_new_pid(int writefd,
return ioc;
}
-
-#ifndef WIN32
QIOChannelCommand *
qio_channel_command_new_spawn(const char *const argv[],
int flags,