diff options
| author | Daniel P. Berrangé | 2021-04-30 13:59:06 +0200 |
|---|---|---|
| committer | Daniel P. Berrangé | 2021-07-14 15:15:52 +0200 |
| commit | cfb47f2178c2c9c81870aab0bc0c93e5758cff86 (patch) | |
| tree | 90e5eae5aa66874933203f0f515ad26a21b7afeb /io | |
| parent | net/rocker: use GDateTime for formatting timestamp in debug messages (diff) | |
| download | qemu-cfb47f2178c2c9c81870aab0bc0c93e5758cff86.tar.gz qemu-cfb47f2178c2c9c81870aab0bc0c93e5758cff86.tar.xz qemu-cfb47f2178c2c9c81870aab0bc0c93e5758cff86.zip | |
io: use GDateTime for formatting timestamp for websock headers
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'io')
| -rw-r--r-- | io/channel-websock.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/io/channel-websock.c b/io/channel-websock.c index 03c1f7cb62..70889bb54d 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -177,15 +177,9 @@ qio_channel_websock_handshake_send_res(QIOChannelWebsock *ioc, static gchar *qio_channel_websock_date_str(void) { - struct tm tm; - time_t now = time(NULL); - char datebuf[128]; + g_autoptr(GDateTime) now = g_date_time_new_now_utc(); - gmtime_r(&now, &tm); - - strftime(datebuf, sizeof(datebuf), "%a, %d %b %Y %H:%M:%S GMT", &tm); - - return g_strdup(datebuf); + return g_date_time_format(now, "%a, %d %b %Y %H:%M:%S GMT"); } static void qio_channel_websock_handshake_send_res_err(QIOChannelWebsock *ioc, |