diff options
| author | Laszlo Ersek | 2015-06-11 02:37:59 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2015-06-11 12:40:30 +0200 |
| commit | 4ebc736e9938a7e88ecc785734b17145bf802a56 (patch) | |
| tree | 7fb191353036df4b1021a4095a36135287b90c98 /iohandler.c | |
| parent | i386/acpi-build: more traditional _UID and _HID for PXB root buses (diff) | |
| download | qemu-4ebc736e9938a7e88ecc785734b17145bf802a56.tar.gz qemu-4ebc736e9938a7e88ecc785734b17145bf802a56.tar.xz qemu-4ebc736e9938a7e88ecc785734b17145bf802a56.zip | |
i386/acpi-build: fix PXB workarounds for unsupported BIOSes
The patch
apci: fix PXB behaviour if used with unsupported BIOS
uses the following condition to see if a "PXB mem/IO chunk" has *not* been
configured by the BIOS:
(!range_base || range_base > range_limit)
When this condition evaluates to true, said patch *omits* the
corresponding entry from the _CRS.
Later on the patch checks for the opposite condition (with the intent of
*adding* entries to the _CRS if the "PXB mem/IO chunks" *have* been
configured). Unfortunately, the condition was negated incorrectly: only
the first ! operator was removed, which led to the nonsensical expression
(range_base || range_base > range_limit)
leading to bogus entries in the _CRS, and causing BSOD in Windows Server
2012 R2 when it runs on OVMF.
The correct negative of the condition seen at the top is
(range_base && range_base <= range_limit)
Fix the expressions.
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'iohandler.c')
0 files changed, 0 insertions, 0 deletions