diff options
| author | Stefan Hajnoczi | 2013-04-05 11:51:01 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2013-04-15 10:18:05 +0200 |
| commit | aad64f3193cbdc3741d10afa0237b6833e46e94e (patch) | |
| tree | fe368dda3f0c10160dc5c833c906dfa1b3bf9545 /iohandler.c | |
| parent | qemu-iotests: filter QEMU_PROG in 051.out (diff) | |
| download | qemu-aad64f3193cbdc3741d10afa0237b6833e46e94e.tar.gz qemu-aad64f3193cbdc3741d10afa0237b6833e46e94e.tar.xz qemu-aad64f3193cbdc3741d10afa0237b6833e46e94e.zip | |
ide: refuse WIN_READ_NATIVE_MAX on empty device
What is the highest addressable sector on an empty CD-ROM? Nothing is
addressable so produce an error.
This patch prevents a divide-by-zero in ide_set_sector() since
s->sectors and s->heads would be 0. Not to mention that a sector=-1
argument would be nonsense.
Note that WIN_READ_NATIVE_MAX can be triggered using hdparm -N 1024
/dev/cdrom. The LBA bit will be set to 1 though, so the only easy way
to go down the ide_set_sector() CHS code path which divides by zero is
to comment out the s->select & 0x40 case for testing.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'iohandler.c')
0 files changed, 0 insertions, 0 deletions