diff options
| author | Eric Blake | 2021-01-13 23:10:12 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2021-01-28 08:08:45 +0100 |
| commit | c3033fd372fdaf5b89190136a74b3d78880b85d6 (patch) | |
| tree | 6c2464ae3f51b43702c448606acb3a6c21b6b634 /iothread.c | |
| parent | qapi: Introduce QAPI_LIST_APPEND (diff) | |
| download | qemu-c3033fd372fdaf5b89190136a74b3d78880b85d6.tar.gz qemu-c3033fd372fdaf5b89190136a74b3d78880b85d6.tar.xz qemu-c3033fd372fdaf5b89190136a74b3d78880b85d6.zip | |
qapi: Use QAPI_LIST_APPEND in trivial cases
The easiest spots to use QAPI_LIST_APPEND are where we already have an
obvious pointer to the tail of a list. While at it, consistently use
the variable name 'tail' for that purpose.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210113221013.390592-5-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'iothread.c')
| -rw-r--r-- | iothread.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/iothread.c b/iothread.c index 69eff9efbc..b9f2751382 100644 --- a/iothread.c +++ b/iothread.c @@ -1,7 +1,7 @@ /* * Event loop thread * - * Copyright Red Hat Inc., 2013 + * Copyright Red Hat Inc., 2013, 2020 * * Authors: * Stefan Hajnoczi <stefanha@redhat.com> @@ -310,8 +310,7 @@ AioContext *iothread_get_aio_context(IOThread *iothread) static int query_one_iothread(Object *object, void *opaque) { - IOThreadInfoList ***prev = opaque; - IOThreadInfoList *elem; + IOThreadInfoList ***tail = opaque; IOThreadInfo *info; IOThread *iothread; @@ -327,12 +326,7 @@ static int query_one_iothread(Object *object, void *opaque) info->poll_grow = iothread->poll_grow; info->poll_shrink = iothread->poll_shrink; - elem = g_new0(IOThreadInfoList, 1); - elem->value = info; - elem->next = NULL; - - **prev = elem; - *prev = &elem->next; + QAPI_LIST_APPEND(*tail, info); return 0; } |