diff options
| author | Peter Maydell | 2018-12-13 13:02:52 +0100 |
|---|---|---|
| committer | Cornelia Huck | 2018-12-20 17:07:24 +0100 |
| commit | 55281a2c53b884d0c2bce31aee592faf20a28eed (patch) | |
| tree | 4b7886dd04456b95c83ef1ebeefd501aff6ba094 /linux-user/cpu_loop-common.h | |
| parent | Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-reque... (diff) | |
| download | qemu-55281a2c53b884d0c2bce31aee592faf20a28eed.tar.gz qemu-55281a2c53b884d0c2bce31aee592faf20a28eed.tar.xz qemu-55281a2c53b884d0c2bce31aee592faf20a28eed.zip | |
hw/s390/ccw.c: Don't take address of packed members
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this.
Avoid the problem by using local copies of the PMCW and SCSW
struct fields in copy_schib_from_guest() and copy_schib_to_guest().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20181213120252.21697-1-peter.maydell@linaro.org>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'linux-user/cpu_loop-common.h')
0 files changed, 0 insertions, 0 deletions