diff options
| author | David Hildenbrand | 2018-04-06 11:35:52 +0200 |
|---|---|---|
| committer | Cornelia Huck | 2018-04-09 13:50:31 +0200 |
| commit | eac53ac598cc43e325658a6889d9951fd7244e11 (patch) | |
| tree | fdaf3dfce8ab3dc5ccce72497e7c0f9087c7d520 /linux-user/linux_loop.h | |
| parent | Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into st... (diff) | |
| download | qemu-eac53ac598cc43e325658a6889d9951fd7244e11.tar.gz qemu-eac53ac598cc43e325658a6889d9951fd7244e11.tar.xz qemu-eac53ac598cc43e325658a6889d9951fd7244e11.zip | |
s390x/kvm: call cpu_synchronize_state() on every kvm_arch_handle_exit()
Manually having to use cpu_synchronize_state() is error prone. And as
Christian Borntraeger discovered, e.g. handle_diag() is currently
missing a cpu_synchronize_state(), as decode_basedisp_s() uses a
general purpose register value internally.
So let's do an overall cpu_synchronize_state(), which fixes at least the
one mentioned BUG. We will clean up the superfluous cpu_synchronize_state()
calls later.
We now also call it (although maybe not neded) for
- KVM_EXIT_S390_RESET -> s390_reipl_request()
- KVM_EXIT_DEBUG -> kvm_arch_handle_debug_exit()
- unmanagable/unimplemented intercepts
- ICPT_CPU_STOP -> do_stop_interrupt() -> cpu gets halted
- Scenarios where we inject an operation exception
- handle_stsi()
I don't think any of these are performance critical. Especially as we
have all information directly contained in kvm_run, there are no
additional IOCTLs to issue on modern kernels.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20180406093552.13016-1-david@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'linux-user/linux_loop.h')
0 files changed, 0 insertions, 0 deletions
