diff options
| author | Thomas Huth | 2021-08-27 14:08:59 +0200 |
|---|---|---|
| committer | Thomas Huth | 2021-09-06 09:07:00 +0200 |
| commit | 87daf898c7bd67ea205516b53302927a0da70902 (patch) | |
| tree | 00b93d412c04a0ecd8d97733fd192e78471da6c6 /meson.build | |
| parent | gitlab-ci: Don't try to use the system libfdt in the debian job (diff) | |
| download | qemu-87daf898c7bd67ea205516b53302927a0da70902.tar.gz qemu-87daf898c7bd67ea205516b53302927a0da70902.tar.xz qemu-87daf898c7bd67ea205516b53302927a0da70902.zip | |
meson.build: Fix the check for a usable libfdt
The check for libfdt currently has a flaw: If there is a system libfdt, the
meson.build code initialized the fdt variable with fdt = cc.find_library(...).
However, if this libfdt is too old and there is no internal dtc module
available, it continues with "fdt" pointing to the old and unusable version.
The check later in the file that tries to detect whether libfdt is necessary
then fails to trigger:
if not fdt.found() and fdt_required.length() > 0
error('fdt not available but required by targets ' + ', '.join(fdt_required))
endif
The build fails then during compilation instead, which is of course bad
since this is quite confusing and already wasted quite some time of the user.
Thus if libfdt is not usable, we should unset the "fdt" variable immediately
again, so that the build already fails during the configuration phase.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/255
Message-Id: <20210827120901.150276-2-thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'meson.build')
| -rw-r--r-- | meson.build | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/meson.build b/meson.build index bf63784812..6f7177428e 100644 --- a/meson.build +++ b/meson.build @@ -1916,6 +1916,7 @@ if have_system fdt_opt = 'internal' else fdt_opt = 'disabled' + fdt = not_found endif endif if fdt_opt == 'internal' |