diff options
| author | Peter Xu | 2022-10-04 20:24:28 +0200 |
|---|---|---|
| committer | Juan Quintela | 2022-11-21 11:58:10 +0100 |
| commit | afed4273b5c9438dfbaa0b4762d0433f295ccdc1 (patch) | |
| tree | 107c82e81998fb3b16efedcfce23d2e18560a4d4 /migration | |
| parent | migration: Fix race on qemu_file_shutdown() (diff) | |
| download | qemu-afed4273b5c9438dfbaa0b4762d0433f295ccdc1.tar.gz qemu-afed4273b5c9438dfbaa0b4762d0433f295ccdc1.tar.xz qemu-afed4273b5c9438dfbaa0b4762d0433f295ccdc1.zip | |
migration: Disallow postcopy preempt to be used with compress
The preempt mode requires the capability to assign channel for each of the
page, while the compression logic will currently assign pages to different
compress thread/local-channel so potentially they're incompatible.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/migration.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/migration/migration.c b/migration/migration.c index 739bb683f3..f3ed77a7d0 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1337,6 +1337,17 @@ static bool migrate_caps_check(bool *cap_list, error_setg(errp, "Postcopy preempt requires postcopy-ram"); return false; } + + /* + * Preempt mode requires urgent pages to be sent in separate + * channel, OTOH compression logic will disorder all pages into + * different compression channels, which is not compatible with the + * preempt assumptions on channel assignments. + */ + if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) { + error_setg(errp, "Postcopy preempt not compatible with compress"); + return false; + } } return true; |