summaryrefslogtreecommitdiffstats
path: root/monitor
diff options
context:
space:
mode:
authorLeonardo Bras2022-06-20 07:39:45 +0200
committerDr. David Alan Gilbert2022-06-22 19:11:17 +0200
commit1abaec9a1b2c23f7aa94709a422128d9e42c3e0b (patch)
tree125d38fcdf0a5c9427a5ab3ebf4ab6b89f89be9d /monitor
parentQIOChannelSocket: Fix zero-copy send so socket flush works (diff)
downloadqemu-1abaec9a1b2c23f7aa94709a422128d9e42c3e0b.tar.gz
qemu-1abaec9a1b2c23f7aa94709a422128d9e42c3e0b.tar.xz
qemu-1abaec9a1b2c23f7aa94709a422128d9e42c3e0b.zip
migration: Change zero_copy_send from migration parameter to migration capability
When originally implemented, zero_copy_send was designed as a Migration paramenter. But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability. Taking into account how recently the change got merged, it was decided that it's still time to make it right, and convert zero_copy_send into a Migration capability. Signed-off-by: Leonardo Bras <leobras@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Acked-by: Peter Xu <peterx@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> dgilbert: always define the capability, even on non-Linux but error if set; avoids build problems with the capability
Diffstat (limited to 'monitor')
-rw-r--r--monitor/hmp-cmds.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 47a27326ee..ca98df0495 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1311,12 +1311,6 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
p->has_multifd_zstd_level = true;
visit_type_uint8(v, param, &p->multifd_zstd_level, &err);
break;
-#ifdef CONFIG_LINUX
- case MIGRATION_PARAMETER_ZERO_COPY_SEND:
- p->has_zero_copy_send = true;
- visit_type_bool(v, param, &p->zero_copy_send, &err);
- break;
-#endif
case MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE:
p->has_xbzrle_cache_size = true;
if (!visit_type_size(v, param, &cache_size, &err)) {