summaryrefslogtreecommitdiffstats
path: root/monitor
diff options
context:
space:
mode:
authorDaniel P. Berrangé2021-02-04 13:48:25 +0100
committerDr. David Alan Gilbert2021-02-08 12:19:51 +0100
commitf61fe11aa6f7f8f0ffe4ddaa56a8108f3ab57854 (patch)
tree9b9a2837f33ce6c5618b7ca01dd1455fd420583f /monitor
parentmigration: Make save_snapshot() return bool, not 0/-1 (diff)
downloadqemu-f61fe11aa6f7f8f0ffe4ddaa56a8108f3ab57854.tar.gz
qemu-f61fe11aa6f7f8f0ffe4ddaa56a8108f3ab57854.tar.xz
qemu-f61fe11aa6f7f8f0ffe4ddaa56a8108f3ab57854.zip
migration: stop returning errno from load_snapshot()
None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns a boolean value. Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> [PMD: Return false/true instead of -1/0, document function] Acked-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20210204124834.774401-4-berrange@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'monitor')
-rw-r--r--monitor/hmp-cmds.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 2b954763e4..6ff050ac3d 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1139,7 +1139,7 @@ void hmp_loadvm(Monitor *mon, const QDict *qdict)
vm_stop(RUN_STATE_RESTORE_VM);
- if (load_snapshot(name, &err) == 0 && saved_vm_running) {
+ if (!load_snapshot(name, &err) && saved_vm_running) {
vm_start();
}
hmp_handle_error(mon, err);