diff options
| author | Philippe Mathieu-Daudé | 2017-07-27 04:42:09 +0200 |
|---|---|---|
| committer | Eric Blake | 2017-07-28 18:58:20 +0200 |
| commit | 158b9aa568eabe614d37882dddc2eea534edc7ae (patch) | |
| tree | 7dd7a5f22295c64bd63b0f968c99a6621c10da53 /nbd | |
| parent | Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170728' into staging (diff) | |
| download | qemu-158b9aa568eabe614d37882dddc2eea534edc7ae.tar.gz qemu-158b9aa568eabe614d37882dddc2eea534edc7ae.tar.xz qemu-158b9aa568eabe614d37882dddc2eea534edc7ae.zip | |
nbd: fix memory leak in nbd_opt_go()
nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf'
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170727024224.22900-5-f4bug@amsat.org>
[introduced in commit 8ecaeae8]
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'nbd')
| -rw-r--r-- | nbd/client.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/nbd/client.c b/nbd/client.c index 509ed5e4ba..0a17de80b5 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -376,9 +376,11 @@ static int nbd_opt_go(QIOChannel *ioc, const char *wantname, if (info->request_sizes) { stw_be_p(buf + 4 + len + 2, NBD_INFO_BLOCK_SIZE); } - if (nbd_send_option_request(ioc, NBD_OPT_GO, - 4 + len + 2 + 2 * info->request_sizes, buf, - errp) < 0) { + error = nbd_send_option_request(ioc, NBD_OPT_GO, + 4 + len + 2 + 2 * info->request_sizes, + buf, errp); + g_free(buf); + if (error < 0) { return -1; } |