diff options
| author | Thomas Huth | 2018-09-20 10:22:27 +0200 |
|---|---|---|
| committer | Thomas Huth | 2018-09-25 17:26:17 +0200 |
| commit | 68cb29ea6585c6fb87ee598583c561cde246873b (patch) | |
| tree | 0b09de3054939723edaf72de9ad92caa84f30753 /net | |
| parent | net: Deprecate the "name" parameter of -net (diff) | |
| download | qemu-68cb29ea6585c6fb87ee598583c561cde246873b.tar.gz qemu-68cb29ea6585c6fb87ee598583c561cde246873b.tar.xz qemu-68cb29ea6585c6fb87ee598583c561cde246873b.zip | |
net/slirp: Deprecate the [hub_id name] parameter tuple
The "name" in the [hub_id name] parameter tuple is the same as a
"netdev_id" (which should be unique), so specifying the hub_id here
is just redundant (it was likely just necessary in the past when
the network subsystem was still using "vlans" only and when it did
not use unique "id"s yet).
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/slirp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/slirp.c b/net/slirp.c index c18060f778..c93b64dd91 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -404,6 +404,8 @@ static SlirpState *slirp_lookup(Monitor *mon, const char *hub_id, monitor_printf(mon, "unrecognized (hub-id, stackname) pair\n"); return NULL; } + warn_report("Using 'hub-id' is deprecated, specify the netdev id " + "directly instead"); } else { nc = qemu_find_netdev(name); if (!nc) { |