summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorLukas Straub2020-05-22 09:53:54 +0200
committerJason Wang2020-06-18 15:05:52 +0200
commit76658541f3950e580ae3be8019f1b4c019a8a638 (patch)
tree5121685f65e42e459c3382c4e5c143abd6d8dd00 /net
parentnet/colo-compare.c: Fix deadlock in compare_chr_send (diff)
downloadqemu-76658541f3950e580ae3be8019f1b4c019a8a638.tar.gz
qemu-76658541f3950e580ae3be8019f1b4c019a8a638.tar.xz
qemu-76658541f3950e580ae3be8019f1b4c019a8a638.zip
net/colo-compare.c: Only hexdump packets if tracing is enabled
Else the log will be flooded if there is a lot of network traffic. Signed-off-by: Lukas Straub <lukasstraub2@web.de> Reviewed-by: Zhang Chen <chen.zhang@intel.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Zhang Chen <chen.zhang@intel.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/colo-compare.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 62ecd38bb7..a609f499b9 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -483,10 +483,12 @@ sec:
g_queue_push_head(&conn->primary_list, ppkt);
g_queue_push_head(&conn->secondary_list, spkt);
- qemu_hexdump((char *)ppkt->data, stderr,
- "colo-compare ppkt", ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr,
- "colo-compare spkt", spkt->size);
+ if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
+ qemu_hexdump((char *)ppkt->data, stderr,
+ "colo-compare ppkt", ppkt->size);
+ qemu_hexdump((char *)spkt->data, stderr,
+ "colo-compare spkt", spkt->size);
+ }
colo_compare_inconsistency_notify(s);
}