diff options
| author | Philippe Mathieu-Daudé | 2020-03-05 18:56:49 +0100 |
|---|---|---|
| committer | Jason Wang | 2020-03-31 15:14:35 +0200 |
| commit | b8c4b67e3ec3918a40234e5c56221f780c7856fc (patch) | |
| tree | 1ca475ca3fe280e0f857cfe1160b52753b53bd72 /net | |
| parent | hw/net/rtl8139: Update coding style to make checkpatch.pl happy (diff) | |
| download | qemu-b8c4b67e3ec3918a40234e5c56221f780c7856fc.tar.gz qemu-b8c4b67e3ec3918a40234e5c56221f780c7856fc.tar.xz qemu-b8c4b67e3ec3918a40234e5c56221f780c7856fc.zip | |
hw/net: Make NetCanReceive() return a boolean
The NetCanReceive handler return whether the device can or
can not receive new packets. Make it obvious by returning
a boolean type.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/filter-buffer.c | 2 | ||||
| -rw-r--r-- | net/hub.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 88da78f821..12e0254287 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -74,7 +74,7 @@ static ssize_t filter_buffer_receive_iov(NetFilterState *nf, * the filter can still accept packets until its internal queue is full. * For example: * For some reason, receiver could not receive more packets - * (.can_receive() returns zero). Without a filter, at most one packet + * (.can_receive() returns false). Without a filter, at most one packet * will be queued in incoming queue and sender's poll will be disabled * unit its sent_cb() was called. With a filter, it will keep receiving * the packets without caring about the receiver. This is suboptimal. @@ -90,7 +90,7 @@ static NetHub *net_hub_new(int id) return hub; } -static int net_hub_port_can_receive(NetClientState *nc) +static bool net_hub_port_can_receive(NetClientState *nc) { NetHubPort *port; NetHubPort *src_port = DO_UPCAST(NetHubPort, nc, nc); @@ -102,11 +102,11 @@ static int net_hub_port_can_receive(NetClientState *nc) } if (qemu_can_send_packet(&port->nc)) { - return 1; + return true; } } - return 0; + return false; } static ssize_t net_hub_port_receive(NetClientState *nc, |