summaryrefslogtreecommitdiffstats
path: root/pc-bios/optionrom/pvh_main.c
diff options
context:
space:
mode:
authorJoe Richey2020-03-03 11:52:47 +0100
committerPaolo Bonzini2020-03-16 22:07:42 +0100
commit770275ed0c0ab05677472efcf184b1a02ab14d07 (patch)
tree69a6e8b7faa06fd3e6f62c76a1d54a3f86922902 /pc-bios/optionrom/pvh_main.c
parentscsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[] (diff)
downloadqemu-770275ed0c0ab05677472efcf184b1a02ab14d07.tar.gz
qemu-770275ed0c0ab05677472efcf184b1a02ab14d07.tar.xz
qemu-770275ed0c0ab05677472efcf184b1a02ab14d07.zip
optionrom/pvh: scan entire RSDP Area
Right now the PVH option rom scans for the RSDP from 0xE0000 to 0xE1FFF. This is probobly a typo, it should scan from 0xE0000 to 0xFFFFF. This is actually an issue on some QEMU versions/machines. For example, when I run QEMU the RSDP is placed at 0xf5ad0 which will not be picked up by the current implementation. This bug still allows a Linux guest to boot (in most configurations) as the kernel will just scan for the RSDP if one isn't provided. Signed-off-by: Joe Richey <joerichey@google.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Fixes: 2785dc7b17 ("optionrom: add new PVH option rom") Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'pc-bios/optionrom/pvh_main.c')
-rw-r--r--pc-bios/optionrom/pvh_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/pc-bios/optionrom/pvh_main.c b/pc-bios/optionrom/pvh_main.c
index a015e1bf22..28e79d7fc4 100644
--- a/pc-bios/optionrom/pvh_main.c
+++ b/pc-bios/optionrom/pvh_main.c
@@ -29,7 +29,7 @@ asm (".code32"); /* this code will be executed in protected mode */
#define RSDP_SIGNATURE 0x2052545020445352LL /* "RSD PTR " */
#define RSDP_AREA_ADDR 0x000E0000
-#define RSDP_AREA_SIZE 2048
+#define RSDP_AREA_SIZE 0x00020000
#define EBDA_BASE_ADDR 0x0000040E
#define EBDA_SIZE 1024