diff options
| author | Markus Armbruster | 2019-04-18 16:53:54 +0200 |
|---|---|---|
| committer | Thomas Huth | 2019-05-08 10:52:14 +0200 |
| commit | d796588ba13b9d9301433bdf4e461ad5e60d9796 (patch) | |
| tree | 1c292cc038dbba4a2c3638bf5a55611f9331de52 /pc-bios/s390-ccw/menu.c | |
| parent | Merge remote-tracking branch 'remotes/kraxel/tags/vga-20190507-pull-request' ... (diff) | |
| download | qemu-d796588ba13b9d9301433bdf4e461ad5e60d9796.tar.gz qemu-d796588ba13b9d9301433bdf4e461ad5e60d9796.tar.xz qemu-d796588ba13b9d9301433bdf4e461ad5e60d9796.zip | |
pc-bios/s390-ccw: Clean up harmless misuse of isdigit()
atoui() and get_index() pass char values to isdigit(). With a
standard isdigit(), we'd get undefined behavior when the value is
negative. Can't happen as char is unsigned on s390x. Even if it
ould, we're actually using isdigit() from pc-bios/s390-ccw/libc.h
here, which works fine for negative values. Clean up anyway, just
to avoid setting a bad example.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190418145355.21100-6-armbru@redhat.com>
[thuth: updated the commit message]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'pc-bios/s390-ccw/menu.c')
| -rw-r--r-- | pc-bios/s390-ccw/menu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c index 82a4ae6315..ce3815b201 100644 --- a/pc-bios/s390-ccw/menu.c +++ b/pc-bios/s390-ccw/menu.c @@ -134,7 +134,7 @@ static int get_index(void) /* Check for erroneous input */ for (i = 0; i < len; i++) { - if (!isdigit(buf[i])) { + if (!isdigit((unsigned char)buf[i])) { return -1; } } |