diff options
| author | John Snow | 2022-02-25 21:59:40 +0100 |
|---|---|---|
| committer | John Snow | 2022-03-07 20:36:41 +0100 |
| commit | 0ba4e76b23fed77d09be7f56da783ab3f0b2d497 (patch) | |
| tree | 734f2cdc04e6616815f62b56d91c37b7d6f06640 /python/qemu | |
| parent | python/aqmp: add _session_guard() (diff) | |
| download | qemu-0ba4e76b23fed77d09be7f56da783ab3f0b2d497.tar.gz qemu-0ba4e76b23fed77d09be7f56da783ab3f0b2d497.tar.xz qemu-0ba4e76b23fed77d09be7f56da783ab3f0b2d497.zip | |
python/aqmp: rename 'accept()' to 'start_server_and_accept()'
Previously, I had a method named "accept()" that under-the-hood calls
bind(2), listen(2) *and* accept(2). I meant this as a simplification and
counterpart to the one-shot "connect()" method.
This is confusing to readers who expect accept() to mean *just*
accept(2). Since I need to split apart the "accept()" method into
multiple methods anyway (one of which strongly resembling accept(2)), it
feels pertinent to rename this method *now*.
Rename this all-in-one method "start_server_and_accept()" instead.
Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/qemu')
| -rw-r--r-- | python/qemu/aqmp/legacy.py | 2 | ||||
| -rw-r--r-- | python/qemu/aqmp/protocol.py | 6 |
2 files changed, 5 insertions, 3 deletions
diff --git a/python/qemu/aqmp/legacy.py b/python/qemu/aqmp/legacy.py index 6baa5f3409..dca1e76ed4 100644 --- a/python/qemu/aqmp/legacy.py +++ b/python/qemu/aqmp/legacy.py @@ -91,7 +91,7 @@ class QEMUMonitorProtocol(qemu.qmp.QEMUMonitorProtocol): self._aqmp.negotiate = True self._sync( - self._aqmp.accept(self._address), + self._aqmp.start_server_and_accept(self._address), timeout ) diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py index 009883f64d..73719257e0 100644 --- a/python/qemu/aqmp/protocol.py +++ b/python/qemu/aqmp/protocol.py @@ -265,8 +265,10 @@ class AsyncProtocol(Generic[T]): @upper_half @require(Runstate.IDLE) - async def accept(self, address: SocketAddrT, - ssl: Optional[SSLContext] = None) -> None: + async def start_server_and_accept( + self, address: SocketAddrT, + ssl: Optional[SSLContext] = None + ) -> None: """ Accept a connection and begin processing message queues. |