diff options
author | John Snow | 2022-02-25 21:59:46 +0100 |
---|---|---|
committer | John Snow | 2022-03-07 20:36:41 +0100 |
commit | 481607c7d35de2bc4d9bec7f4734036fc467f330 (patch) | |
tree | b647655cb39d9e772675221bdf525906f6a49032 /python/tests | |
parent | python/aqmp: stop the server during disconnect() (diff) | |
download | qemu-481607c7d35de2bc4d9bec7f4734036fc467f330.tar.gz qemu-481607c7d35de2bc4d9bec7f4734036fc467f330.tar.xz qemu-481607c7d35de2bc4d9bec7f4734036fc467f330.zip |
python/aqmp: add start_server() and accept() methods
Add start_server() and accept() methods that can be used instead of
start_server_and_accept() to allow more fine-grained control over the
incoming connection process.
(Eagle-eyed reviewers will surely notice that it's a bit weird that
"CONNECTING" is a state that's shared between both the start_server()
and connect() states. That's absolutely true, and it's very true that
checking on the presence of _accepted as an indicator of state is a
hack. That's also very certainly true. But ... this keeps client code an
awful lot simpler, as it doesn't have to care exactly *how* the
connection is being made, just that it *is*. Is it worth disrupting that
simplicity in order to provide a better state guard on `accept()`? Hm.)
Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-9-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/tests')
-rw-r--r-- | python/tests/protocol.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/python/tests/protocol.py b/python/tests/protocol.py index 5e442e1efb..d6849ad306 100644 --- a/python/tests/protocol.py +++ b/python/tests/protocol.py @@ -43,11 +43,18 @@ class NullProtocol(AsyncProtocol[None]): async def _do_start_server(self, address, ssl=None): if self.fake_session: + self._accepted = asyncio.Event() self._set_state(Runstate.CONNECTING) await asyncio.sleep(0) else: await super()._do_start_server(address, ssl) + async def _do_accept(self): + if self.fake_session: + self._accepted = None + else: + await super()._do_accept() + async def _do_connect(self, address, ssl=None): if self.fake_session: self._set_state(Runstate.CONNECTING) |