diff options
| author | Markus Armbruster | 2018-07-03 10:53:35 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2018-07-03 23:18:56 +0200 |
| commit | 0fa39d0b0374b983535de8591e5e561401d1d5c6 (patch) | |
| tree | 59d236d557bab134147b6d32d2ed8434cd52f9f3 /qapi | |
| parent | tests/test-qga: Demonstrate the guest-agent ignores "id" (diff) | |
| download | qemu-0fa39d0b0374b983535de8591e5e561401d1d5c6.tar.gz qemu-0fa39d0b0374b983535de8591e5e561401d1d5c6.tar.xz qemu-0fa39d0b0374b983535de8591e5e561401d1d5c6.zip | |
qmp qemu-ga: Revert change that accidentally made qemu-ga accept "id"
Commit cf869d53172 "qmp: support out-of-band (oob) execution" changed
how we check "id":
Note that in the patch I exported qmp_dispatch_check_obj() to be
used to check the request earlier, and at the same time allowed
"id" field to be there since actually we always allow that.
The part after "and" is ill-advised: it makes qemu-ga accept and
ignore "id". Revert.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180703085358.13941-10-armbru@redhat.com>
Diffstat (limited to 'qapi')
| -rw-r--r-- | qapi/qmp-dispatch.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 935f9e159c..3d5d5e110f 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -52,8 +52,6 @@ QDict *qmp_dispatch_check_obj(const QObject *request, Error **errp) "QMP input member 'arguments' must be an object"); return NULL; } - } else if (!strcmp(arg_name, "id")) { - continue; } else if (!strcmp(arg_name, "control")) { if (qobject_type(arg_obj) != QTYPE_QDICT) { error_setg(errp, |